-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major progress on Cogent Mail #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d the new imapMu, mail actions such as Move work without hanging while caching is happening!
…ected EOF error when reading a message sent from Cogent Mail in Cogent Mail, and it was also causing the HTML formatting to not work in Mac Mail; gmail apparently has some automatic tolerance thing that adds the part closing statements for you, which is why it worked there (it even fixed it in the so-called 'Original Message', so I only saw the actual problem when I downloaded the true original message locally)
… labeling instead of more rigid one-to-many mailboxes
…y mailbox selection
…ed by user actions; no-op if already selected
rcoreilly
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest CacheData -> CacheItem or something more semantic. try to avoid Data except for datafs :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes many advancements to Cogent Mail, improving its GUI, caching, storage, labeling, actions, and many other things. It is still not fully ready for end-user use, but it is much closer now.